[TON-388] feat(aws_quickstart): port InstrumentationResourceTypes parameter to main_workflow and main_extended_workflow templates#313
Closed
raymondeah wants to merge 6 commits into
Conversation
…main_extended and main_extended_workflow v4.10.0 (PR #306) added the InstrumentationResourceTypes parameter only to main_v2.yaml. main_extended.yaml and main_extended_workflow.yaml are the templates UI launches actually use going forward, so the parameter and the DatadogSite + InstrumentationResourceTypes passthrough to the role stack belong there too. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…t to main_workflow (drop main_extended) main_extended.yaml isn't on the UI launch path; revert there and apply to main_workflow.yaml instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
raymondeah
changed the title
…t-instrumentation-resource-types-to-extended # Conflicts: # aws_quickstart/CHANGELOG.md
raymondeah
changed the title
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Sergio-Na
reviewed
May 27, 2026
| Type: CommaDelimitedList | ||
| Description: >- | ||
| Comma-separated list of AWS resource types (UDM form, e.g. aws:ec2:instance, aws:ecs:cluster, aws:eks:cluster) | ||
| that the Datadog integration role should be granted the IAM permissions required to instrument with the Datadog |
Contributor
There was a problem hiding this comment.
This might be on me, but this sentence is very hard to read. What about this instead
Comma-separated list of AWS resource types, in UDM format, that Datadog uses to determine which additional IAM permissions to grant the integration role. These permissions are used for Datadog Agent instrumentation. Leave blank to skip granting extra instrumentation permissions.
Contributor
Author
There was a problem hiding this comment.
true, good call and thanks for the suggestion🙇🏻♂️ just pushed c7ae7ad to update the description
Sergio-Na
reviewed
May 27, 2026
| InstrumentationResourceTypes: | ||
| Type: CommaDelimitedList | ||
| Description: >- | ||
| Comma-separated list of AWS resource types (UDM form, e.g. aws:ec2:instance, aws:ecs:cluster, aws:eks:cluster) |
Sergio-Na
approved these changes
May 27, 2026
…parameter description Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #314 (TON-513) which shipped the same parameter port to master. Closing without merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small extension of #306 which adds the same parameters to the
main_extendedandmain_extended_workflowtemplates